Conversation
The search API returned JSON `null` instead of `[]` when no results matched, because Go's nil slice serializes as null. The frontend then crashed on `null.length`, breaking the Escape handler and freezing the command palette. Fix: ensure the server handler always returns an empty array. Add a frontend null-coalesce guard as defense in depth. Fixes #34 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
null, not[]. The frontend crashed onnull.length, breaking the component and its Escape handler.?? []null-coalesce as defense in depthTest plan
TestSearch_ZeroResultsserver test asserts results is[]notnullFixes #34
🤖 Generated with Claude Code